Fix sourcemaps #9371
Merged
Fix sourcemaps #9371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this does not completely fix the problem with sourcemaps, because all of the source files have their directory structure flattened. It could probably only be solved by passing the Update: Fixed! |
Zales0123
added
the
Potential Bug
teohhanhui
force-pushed
the
fix/sourcemaps
branch
from
3d02f85
to
2ce1a6d
Compare
|
And the problem with the directory structure is fixed! 😄 |
pamil
approved these changes
May 2, 2018
|
Niice, thank you a lot, Teoh! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be fine for Node.js compatibility, since yarn doesn't support node < v4 anyway. And
for...ofwith arrays has been supported since node v4: https://node.green/#ES2015-syntax-for--of-loops-with-arrays