Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated copyright note #9545

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Remove duplicated copyright note #9545

merged 1 commit into from
Jul 3, 2018

Conversation

enekochan
Copy link
Contributor

@enekochan enekochan commented Jul 2, 2018 •
edited
Loading

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

@Zales0123 Zales0123 changed the base branch from master to 1.1 July 3, 2018 08:24
@Zales0123
Copy link
Member

Thank you @enekochan for this PR :) However, as it's a bug fix, it should be opened to branch 1.1, could you please rebase with it?

@pamil pamil changed the base branch from 1.1 to 1.2 July 3, 2018 09:08
@pamil
Copy link
Contributor

pamil commented Jul 3, 2018

In fact, these two classes were introduced in 1.2, so it should target that branch. I've made the rebase for you :)

@enekochan
Copy link
Contributor Author

Yes, I targeted master because those files are new in 1.2 :)

@pamil pamil merged commit ec3f7b7 into Sylius:1.2 Jul 3, 2018
@pamil
Copy link
Contributor

pamil commented Jul 3, 2018

Thank you, @enekochan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enekochan @Zales0123 @pamil @lchrusciel