[SF7] Fix resource loader #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
fix/resource-loader
branch
2 times, most recently
from
0d6fcbf
to
c349afa
Compare
loic425
force-pushed
the
fix/resource-loader
branch
from
c349afa
to
8d2e528
Compare
diimpp
reviewed
May 29, 2024
| */ | ||
| public function getResolver() | ||
| public function getResolver(): LoaderResolverInterface |
There was a problem hiding this comment.
Since it will crash if getResolver will be called before setResolver, let's handle it the same as in symfony.
loic425
force-pushed
the
fix/resource-loader
branch
from
9ea6acd
to
6a496c5
Compare
loic425
force-pushed
the
fix/resource-loader
branch
from
6a496c5
to
da5f740
Compare
diimpp
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #887