[SF7] Fix analysis errors #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
May 23, 2024
loic425
commented
| Q | A |
|---|---|
| Bug fix? | yes on SF7 branch |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
loic425
force-pushed
the
fix/psalm-errors
branch
2 times, most recently
from
3efee6e
to
1102e08
Compare
Merged
loic425
commented
May 29, 2024
| */ | ||
| public function transform($value) | ||
| public function transform($value): mixed |
diimpp
reviewed
May 29, 2024
| */ | ||
| public function transform($value) | ||
| public function transform($value): mixed |
There was a problem hiding this comment.
Suggested change
| public function transform($value): mixed | |
| public function transform(mixed $value): mixed |
There was a problem hiding this comment.
/** @param int|string|null $value */
public function reverseTransform($value): ?ResourceInterfaceNot sure how it's even working, since correct typehint is
public function reverseTransform(mixed $value): mixed;There was a problem hiding this comment.
you mean for the return typehint? this is ok, you can restrict it but I don't even remember on which php version.
diimpp
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.