Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delay_constant to sort-tags.xsl #6

Merged
merged 3 commits into from
Nov 25, 2019

Conversation

glatosinski
Copy link
Contributor

Signed-off-by: Grzegorz Latosinski glatosinski@antmicro.com

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@glatosinski
Copy link
Contributor Author

I added a simple test that verifies sorting of input and delay_constant tags

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
Signed-off-by: Grzegorz Latosinski <glatosinski@antmicro.com>
@mithro mithro merged commit aab7ab0 into chipsalliance:master Nov 25, 2019
@mithro
Copy link
Contributor

mithro commented Nov 25, 2019

LGTM! Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants