-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BINARY] : Bump binary to 1.69.7 #51
Conversation
The stop_on_error seems to be ignored :/ i’ll look tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This should finally close #31 🎉
Though I wonder if the bumped version is the reason why tests fail here
To work with |
@andersonamuller would you like to open a PR for this change? |
Sorry @bocharsky-bw, I just wated to bring to attention, no time ATM for a PR. We are not even using the bundle yet as the Alpine was a requirement and we had to incorporate in our docker build the download of SASS binary. |
Yeah sure, thanks for the head-ups though! If there's a volunteer who would like to help with necessary changes for Alipnie support in this bundle - feel free to take it |
@bocharsky-bw , I've added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me now 👍
Unfortunately, as you can see with my latest few commits - test failures are related here. Could you take a look?
The errors seems to be only related to stop_on_error option right ? |
@smnandre yeah happens in hm, the |
I think it's related to recent changes in the async handling in sass. So we may remove temporary the test ? 👼 |
Ah, that sounds possible... OK, I temporarily marked it as skipped. If anybody has ideas on how to fix it (or test that in a better way) - please, open a PR. Thank you guys! |
As it is mentioned in the issue 31, the sass binary has been updated and it now provides official releases for musl LibC and for Android.
Closes #31