use new bundle strategy

[jrushlow]

wip - see symfony/symfony-docs#19793

• double check the structure against https://symfony.com/doc/current/bundles/best_practices.html && the PR mentioned above
• test locally
• test in linked app on linux
• test in linked app on macos
• test again...
• add test to ensure if lifetime is changed in userland - the new value is used in the helper... this may already be a thing - To be completed under [tests] add test to ensure if lifetime is changed in userland - the new value is used in the helper... #187

[yceruto]

About the directory structure, there is one more possible change that matches the modern skeleton: the translations/ directory can be moved to the root level too

[jrushlow]

About the directory structure, there is one more possible change that matches the modern skeleton: the translations/ directory can be moved to the root level too

@yceruto - I was just thinking about the best way to handle that. And I believe it'll be done outside of this PR. reset-password && verify-email have the exact same translations - to keep from adding too much noise to this PR - I need to mv and add any missing translations that exist in one bundle but not the other.

[jrushlow]

@yceruto - I'm wondering if we could / should add array "shape" annotation(s) to https://github.com/symfony/symfony/blob/65ccca07588b108246a2aa3f5c8214e045c376be/src/Symfony/Component/HttpKernel/Bundle/AbstractBundle.php#L38 for better DX

PHPStan Squawk:

Fixed by: 089cec8

[bocharsky-bw]

Code looks good to me