Fixes issue #18 #19
Merged
Fixes issue #18 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Mar 14, 2018
Readme.md
Outdated
| @@ -161,3 +161,6 @@ script: | |||
|
|
|||
| ``` | |||
|
|
|||
| ## Known Issue | |||
There was a problem hiding this comment.
Lets use ### and put it under the Private services...
Readme.md
Outdated
| @@ -161,3 +161,6 @@ script: | |||
|
|
|||
| ``` | |||
|
|
|||
| ## Known Issue | |||
|
|
|||
| Since this makes all seervices public, as a consequence errors like accessing private services in your code will not be caught in the tests. | |||
There was a problem hiding this comment.
Maybe add it more as a warning. "Be aware that if you make all services public then you will not get any errors if your bundles access public services".. or something like that.
Nyholm
approved these changes
Feb 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.