test: Add routing tests #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I appriciate this. But I think we should bump our composer.json to only support symfony versions that are currently maintained. (or soon to be maintained) Ie, 4.4, 5.3, 5.4 and 6.0. |
chapterjason
force-pushed
the
routing-tests
branch
from
97e5de2
to
ecd89ca
Compare
|
@Nyholm I was searching for the Issue and noticed that the we can deprecate also the |
|
Wait for #47 |
chapterjason
force-pushed
the
routing-tests
branch
from
0ede019
to
f35e3b9
Compare
chapterjason
force-pushed
the
routing-tests
branch
from
f35e3b9
to
4747e9f
Compare
|
@Nyholm Should also be ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed the missing support for Symfony below 4.1.
symfony/symfony#26085