Updates #2
Merged
Updates #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h new adding documents patch route
…ab a users ip address
addDocuments as plural to match the new APIRoute for adding documents
stevula
approved these changes
Sep 15, 2016
|
Should be live on npm now |
tynahuynh
pushed a commit
that referenced
this pull request
Feb 15, 2018
The gem needs to be have its own error class that can parse the response and fail with so its easier for gem consumers to deal with errors consistently. I’d add more but we need to make changes elsewhere. This is just part 1. We should be merging in PR #2 to start and building off that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users.js now allows for query and page parameters in the url to be added to /users Get routes. User.js has an updated function addDoc to addDocuments to match the newer api route for adding multiple documents at a time. Other minor updates include Helpers.js where i use underscore to grab the ip address which requires package.json to have underscore npm package installed.