Jdk10/issue12 #140
Open
Jdk10/issue12 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the jdk8 the javah command is deprecated and is removed at least in the jdk10. The javac is now doing the work, the necessary changes are added to the pom.xml. To mark the parts which should be exposed into the header files, it is important to use the java native annotation @Native. Only the files which contains exposed information are generated.
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
========================================
Coverage 46.4% 46.4%
Complexity 892 892
========================================
Files 60 60
Lines 9875 9875
Branches 1611 1611
========================================
Hits 4582 4582
Misses 4830 4830
Partials 463 463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr: Remove the usage of javah to support JDK above 8.
With the JDK8 the javah command is deprecated and is removed in jdk9, the function is now supported by the javac command. But the source code needs the java native annotation. The Patch add the necessary annotations and enable the header generation by the compiler.