-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cil astra #747
Fix cil astra #747
Conversation
Failures are (around line 10000)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best to document in the file why this needs to be done. We will forget...
Does cmake -E rm
accept multiply files to make this a bit shorter?
do we really need to call to the |
The rationale is:
As far as I understand, there is no command I can run before update. So I am hijacking it to first remove the unwanted files, then continue with the standard update that would be done in But maybe this will only work for the 3.1.0 VM? |
Fixes updates for CIL ASTRA git-failing because an untracked file is in the sources.
Tested on updating SIRF 3.1.0 VM downloaded from zenodo with the command
This updates SIRF to 3.3.0 (master).
Still it doesn't update CIL, for instance, but it does rebuild ISMRMRD to 1.7 with support for the utilities, thereby fixing #745