Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass DISABLE_Gadgetron to SIRF #751

Closed

Conversation

paskino
Copy link
Contributor

@paskino paskino commented Aug 2, 2022

Partly addresses #750 by setting DISABLE_Gadgetron=(NOT ${BUILD_Gadgetron}) in SIRF's external build.

This is however, still not entirely correct as it does not address:

  1. USE_SYSTEM_Gadgetron=ON
  2. the case in which BUILD_Gadgetron=ON but the user wants (why would they?) to disable Gadgetron's support in SIRF.

addresses create SIRF_DISABLE_Gadgetron etc SyneRBI#750
@KrisThielemans
Copy link
Member

I'm not really sure if NOT works that way. Does it?

In any case, I don't think this will cope with what we want on Windows. There BUILD_Gadgetron=OFF but (at least normally) SIRF's DISABLE_Gadgetron=OFF.

I see no other way than introducing SIRF_DISABLE_Gadgetron.

@paskino
Copy link
Contributor Author

paskino commented Aug 2, 2022

It does work, as I used it to build on my Windows machine lately. However, it doesn't fullfil the requirements and SIRF_DISABLE_Gadgetron is a simpler solution.

@paskino paskino closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants