Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add norm function for NiftyResampler #1182

Closed
Letizia97 opened this issue Mar 22, 2023 · 1 comment · Fixed by #1186
Closed

Add norm function for NiftyResampler #1182

Letizia97 opened this issue Mar 22, 2023 · 1 comment · Fixed by #1186
Assignees
@evgueni-ovtchinnikov

Comments

@Letizia97
Copy link

In order to perform motion compensation with CIL's PDHG, NiftyResampler should have a norm function.
This was referenced Apr 17, 2023
Merged
Merged
evgueni-ovtchinnikov added a commit that referenced this issue Apr 26, 2023
@evgueni-ovtchinnikov
interfaced and tested resampler norm in Python, fixes #1182
6d3b878
@evgueni-ovtchinnikov
Copy link
Contributor

@Letizia97 could you please pull resampler-norm branch from SyneRBI/SIRF and try norm() method added to NiftyResampler by PR #1186? You will find a simple test in test_pReg.py - perhaps you could do a more thorough testing, could you?

Thank you,
Evgueni

evgueni-ovtchinnikov added a commit that referenced this issue Jul 6, 2023
@evgueni-ovtchinnikov
Resampler norm (#1186)
08c86f4 
* modified JacobiCG to accomodate Resampler projectors

* added sptr wrapper class to use JacobiCG with Resampler projectors

* [ci skip] corrected indentation in JacobiCG.h (last line)

* [ci skip] attempted implementing resampler norm, build fails

* [ci skip] tried to fix resampler norm, build still fails

* small fixes in BFOperator and NiftyResampler::norm

* restored old usage of dot and corrected Wrapped_sptr in JacobiCG.h

* implemented and tested NiftyResampler::norm

* interfaced and tested resampler norm in Python, fixes #1182

* got rid of assert in resampler norm method to placate Codacy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evgueni-ovtchinnikov evgueni-ovtchinnikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resampler norm SyneRBI/SIRF
2 participants
@evgueni-ovtchinnikov @Letizia97