Add support for Hass.io #3732

fredrike · 2019-07-04T20:47:38Z

Motivation: The Home Assistant package runs HA natively in Python, the preferred way is to run hass.io and let it manage HA via Docker.

Checklist

Build rule all-supported completed successfully
Package upgrade completed successfully
New installation of package completed successfully

chickenandpork · 2019-07-11T09:05:47Z

FWIW I See you've taken great care to provide a lot of things to make this a well-behaved and functionality-complete config. I worry that the supported architecture is very limited.

In hassio.sh@32 it might be worth noting that 172.30.32/24 is hard-coded in hass supervisor? (is it?) Same file, line 36, might be worth documenting the logic of the "attach to running image or attempt to start a new image to attach to" if I'm understanding correctly.

You've clearly looked closely at details, and I expect this is running on your person system? It makes me want to try it on my avoton.

I notice you're commenting on #3731 as well.

fredrike · 2019-07-11T19:35:58Z

172.30.32/24 is hardcoded in hassio-supervisor. I've been in contact with the team of hassio for the changes in this and most of the hass.sh is adapted from the original hassio-service file. https://github.com/home-assistant/hassio-installer/blob/master/files/hassio-supervisor

fredrike · 2019-07-20T07:10:50Z

@chickenandpork When can I expect this to be merged?

chickenandpork · 2019-07-21T05:02:09Z

Often that depends on who else has time to test and verify. The builds for Synology are really expensive in terms of time and test tiers, so they get scheduled when there are some ready and the personal projects are also complete. My original python3.5.6 work took so long, 3.6.8 was out. Maybe needed more cross-platform verification.

I do think we need a way to automate some portion of testing so that we can check for compatibility a bit more autonomously. I’m used to working at companies that do this automatically, trying to think on how we can move to something a bit more efficient. I’ve got some work in that area to explore.

Personally, I’m curious to try your work in a week or so when I get back from travels.

fredrike · 2019-07-21T05:46:00Z

I have 16 ❤️ here not sure if that means users that have tested and verified but at least it's something 😄

Tack your time and enjoy your travels @chickenandpork

Edit:

I've also got 40 ⬆️ here

jokerigno · 2019-07-24T07:48:56Z

Well, if this can help, I use it on my xpenology NAS for 2 weeks.
Very stable and reliable!

ymartin59 · 2019-07-28T05:46:54Z

@fredrike Thanks for this contribution.
I have a question about service start/stop, I find it strange to chain busybox start-stop-daemon, a custom script and then docker run. From my point of view (probably naive), it should be enough start_daemon method to invoke "docker run" and stop_daemon to invoke "docker stop". May you explain why implementation seems so "complicated"?

ymartin59

As it is our first Docker-based package, many questions...
Then improvement proposal to reduce maintenance effort.

spk/hassio/Makefile

spk/hassio/src/hassio.sh

spk/hassio/Makefile

fredrike · 2019-08-01T18:50:40Z

@ymartin59 When a package is upgraded, will the files in the new package replace the old ones (in my case the hassio.sh file)?

What is the best way to ensure that the hassio.json file is moved to etc when upgrading? Will this do it 46e4571?

fxstein · 2020-01-13T23:11:28Z

@fredrike @chickenandpork Thank you both!

bruvv · 2020-01-14T09:21:21Z

After 6 months are we finally going to see this merged 😳
Thanks everyone involved especially @fredrike for your work! Can't wait to see this pop up in my app store

G3rry71 · 2020-01-14T13:07:50Z

After 6 months are we finally going to see this merged 😳
Thanks everyone involved especially @fredrike for your work! Can't wait to see this pop up in my app store

Congratulation team!

jokerigno · 2020-01-16T14:11:21Z

Thank you all!

fredrike · 2020-01-16T15:14:51Z

Thank you all!

It is still not merged so I'm not super optimistic..

fxstein · 2020-01-16T15:52:26Z

@chickenandpork @ymartin59 We all would very much appreciate your attention on getting this PR close out. Thank you very much!

chickenandpork · 2020-01-16T16:35:08Z

7abccb39 eliminates the concerns I raised:

I think the existing work still suffers from lacking the restart that happens on a hassio on a RaspPi: when HA stops in a Pi, IIRC the Pi restarts. This means it doesn't need to get right the shutdown of addons and such. I want to clarify that I don't see this as a failing: there's a previous comment about being similar to upstream, but upstream has some luxuries :) I really appreciate @fredrike 's work here.

Stop and Start are cleaner than I saw before; this is awesome.

Stop still leaves homeassistant/amd64-hassio-dns:1 running, plus my selected add-ons, but I'm OK accepting a later fix for that as a bugfix. Removal stops homeassistant/amd64-hassio-dns:1 but not my selected add-ons

"Updating" 20191224-1 to 20191224-1 seems to make no change. Delete and install looks OK if I manually stop and delete my add-ons. Unlike previous runs, this is good in the mode of "just reinstall and it'll do the right thing". More people using this will clarify what circumstances images might still be running or any other issues.

I accept but I can't speak for @ymartin59

Be aware that accepted PRs become mergeable but there's a lag between that and building a release (based on space and cycles on a CI I think) but this one is a quick build so not as bad for this SPK.

fredrike · 2020-01-18T08:01:57Z

7abccb39 eliminates the concerns I raised:

I think the existing work still suffers from lacking the restart that happens on a hassio on a RaspPi: when HA stops in a Pi, IIRC the Pi restarts. This means it doesn't need to get right the shutdown of addons and such. I want to clarify that I don't see this as a failing: there's a previous comment about being similar to upstream, but upstream has some luxuries :) I really appreciate @fredrike 's work here.

Stop and Start are cleaner than I saw before; this is awesome.

Stop still leaves homeassistant/amd64-hassio-dns:1 running, plus my selected add-ons, but I'm OK accepting a later fix for that as a bugfix. Removal stops homeassistant/amd64-hassio-dns:1 but not my selected add-ons

Uninstall of the package should remove the dns container. It would be fairly easy to make sure that all containers are stopped when stopping the package. Together with removing all related images.

"Updating" 20191224-1 to 20191224-1 seems to make no change. Delete and install looks OK if I manually stop and delete my add-ons. Unlike previous runs, this is good in the mode of "just reinstall and it'll do the right thing". More people using this will clarify what circumstances images might still be running or any other issues.

I accept but I can't speak for @ymartin59

Be aware that accepted PRs become mergeable but there's a lag between that and building a release (based on space and cycles on a CI I think) but this one is a quick build so not as bad for this SPK.

@fxstein, do you have an idea of how to detect the missing entrypoint.js that happens once in a while (the fix is to restart the package)?

chickenandpork · 2020-01-18T16:36:55Z

@ymartin59 I think this resolved the four issues you raised 2019-11-30:

SPK_VER: @fredrike went with a static YYYYMMDD manually changed as a version
SPK_REV: @fredrike change to 1
ADMIN_PORT: @fredrike removed
SERVICE_PORT 8123 collides with homeassistant::SERVICE_PORT: @fredrike marked the incompatibility in the SPK Makefile.

Looking for your OK with this work, and that any remaining issues can be pushed to a bug fix, so that @fredrike can get this merged.

fredrike · 2020-01-19T15:04:16Z

spk/hassio/src/service-setup.sh

+        docker network rm hassio
+
+        if [ "${wizard_remove_addons}" == "true" ]; then
+            # Remove addons


@chickenandpork, so you are saying that this doesn't work?

ymartin59

OK I publish for x64 architectures as beta for a first revision.

ymartin59 · 2020-01-19T21:47:14Z

spk/hassio/Makefile

+STARTABLE = yes
+DISPLAY_NAME = Hass.io
+CHANGELOG = ""
+


Suggested change

BETA = 1

fredrike · 2020-01-20T04:33:50Z

OK I publish for x64 architectures as beta for a first revision.

Great, thanks! Docker is only supported on x64. May i ask why beta and why you are so skeptical on this?

mp68 · 2020-01-23T08:17:56Z

Due to popular demand: When can we expect this to become available through the package manager?

fredrike · 2020-01-26T09:01:10Z

spk/hassio/src/service-setup.sh

+
+service_poststop ()
+{
+    docker stop hassio_supervisor homeassistant


ADDONS=$(jq -r '.user| keys| map("addon_"+.)| join(" ")' $(jq -r '.data + "/addons.json"' ${CFG_FILE})) docker stop $ADDONS

ymartin59 · 2020-01-26T10:46:02Z

At the moment, publish fails. A fix in spkrepo or in package is required: SynoCommunity/spkrepo#39. Investigations in progress.

ymartin59 · 2020-01-26T10:52:31Z

@fredrike May you please register here with your github username: https://synocommunity.com/register so that I declare you as package owner.

dvisser · 2020-09-10T04:50:03Z

is home assistant development still active? I see the package as beta and cant seem to find much development/progression? I could be looking in the wrong places though. Thanks.

fredrike · 2020-09-10T08:57:32Z

is home assistant development still active?

Well, I don't have any bugs to solve..

I see the package as beta and cant seem to find much development/progression?

It is @ymartin59 that requested it to be BETA, #3732 (review). I would be happy to remove the BETA flag but have not been following the https://community.home-assistant.io/t/hass-io-on-synology-dsm-native-package/125559 thread closely but it seems like @BeardedConti manages to get most configurations to run flawlessly.

bruvv · 2020-09-10T09:45:15Z

is home assistant development still active?

Well, I don't have any bugs to solve..

I see the package as beta and cant seem to find much development/progression?

It is @ymartin59 that requested it to be BETA, #3732 (review). I would be happy to remove the BETA flag but have not been following the https://community.home-assistant.io/t/hass-io-on-synology-dsm-native-package/125559 thread closely but it seems like @BeardedConti manages to get most configurations to run flawlessly.

Well when removing the package it doesn't remove all the created containers. Like hassio_dns and hassio_cli and some more I cannot remember atm

fredrike · 2020-09-10T10:43:36Z

I've updated the package, but I don't see the BETA flag..

BeardedTinker · 2020-09-11T05:46:28Z

I've checked few time and also don't see BETA flag.

fredrike · 2020-09-16T07:09:16Z

But it is there in the community repository:

ymartin59 · 2020-09-20T09:15:14Z

Your Package Center has not yet updated content: https://synocommunity.com/package/hassio

bruvv · 2020-09-20T10:05:23Z

Your Package Center has not yet updated content: https://synocommunity.com/package/hassio

I readded the community to my package manager but for me it is still showing up as beta as well ;) and I do not see the new version.
Could it be because of the date that is exactly the same?

Date
    2020-01-26 14:05:46.717836

edit:
When removing the beta option in synology's package manager, removing hassio and relogging I finally saw the new update 👍

fredrike added 8 commits June 30, 2019 21:00

initial hass.io support

3149131

better start-stop script

e204d60

fixed daemon version

4b516bd

version bump

df7dc0c

only supports x64 arch

e797b68

fix newline

8f31d5a

updated install_ui

4e52c6e

new install UI

d00caa4

fredrike force-pushed the hass.io branch from 8302cbc to d00caa4 Compare July 9, 2019 13:26

fredrike mentioned this pull request Jul 13, 2019

Homeassistant 0.87.1 and Python 3.6.8 - fix cross-compilation issues #3731

Closed

chickenandpork mentioned this pull request Jul 19, 2019

Home Assistant update? #3740

Closed

add docker stop to stop script

3a23285

remove hassio network at uninstall too

f262cc0

ymartin59 requested changes Jul 28, 2019

View reviewed changes

spk/hassio/Makefile Outdated Show resolved Hide resolved

spk/hassio/Makefile Outdated Show resolved Hide resolved

spk/hassio/src/hassio.sh Outdated Show resolved Hide resolved

spk/hassio/src/hassio.sh Outdated Show resolved Hide resolved

spk/hassio/Makefile Outdated Show resolved Hide resolved

fredrike added 4 commits July 31, 2019 08:32

fixes for @ymartin59

d1b1997

service_preupgrade

46e4571

add fix_usb_devices

e23d602

lint fixes

eb505bb

fredrike force-pushed the hass.io branch from 4c86912 to eb505bb Compare August 1, 2019 18:22

fredrike added 3 commits August 2, 2019 07:38

fix usb_devices function

f5c97b7

fix uninstall (so new installs will work)

337ede0

fix upgrade

008c358

fredrike requested a review from ymartin59 January 13, 2020 23:06

chickenandpork approved these changes Jan 16, 2020

View reviewed changes

fredrike commented Jan 19, 2020

View reviewed changes

ymartin59 approved these changes Jan 19, 2020

View reviewed changes

spk/hassio/Makefile

STARTABLE = yes

DISPLAY_NAME = Hass.io

CHANGELOG = ""

Copy link

Contributor

ymartin59 Jan 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

BETA = 1

ymartin59 merged commit 814a835 into SynoCommunity:master Jan 19, 2020

ymartin59 added the status/to-publish label Jan 19, 2020

fredrike commented Jan 26, 2020

View reviewed changes

ymartin59 removed the status/to-publish label Jan 26, 2020

fredrike mentioned this pull request Sep 10, 2020

hassio: Remove support containers and images, require DSM 6.2 #4173

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Hass.io #3732

Add support for Hass.io #3732

fredrike commented Jul 4, 2019

chickenandpork commented Jul 11, 2019

fredrike commented Jul 11, 2019

fredrike commented Jul 20, 2019

chickenandpork commented Jul 21, 2019 •

edited

Loading

fredrike commented Jul 21, 2019 •

edited

Loading

jokerigno commented Jul 24, 2019

ymartin59 commented Jul 28, 2019

ymartin59 left a comment

fredrike commented Aug 1, 2019

fxstein commented Jan 13, 2020

bruvv commented Jan 14, 2020 •

edited

Loading

G3rry71 commented Jan 14, 2020

jokerigno commented Jan 16, 2020

fredrike commented Jan 16, 2020

fxstein commented Jan 16, 2020

chickenandpork commented Jan 16, 2020 •

edited

Loading

fredrike commented Jan 18, 2020

chickenandpork commented Jan 18, 2020

fredrike Jan 19, 2020

ymartin59 left a comment

ymartin59 Jan 19, 2020

fredrike commented Jan 20, 2020 •

edited

Loading

mp68 commented Jan 23, 2020

fredrike Jan 26, 2020

ymartin59 commented Jan 26, 2020

ymartin59 commented Jan 26, 2020

dvisser commented Sep 10, 2020

fredrike commented Sep 10, 2020

bruvv commented Sep 10, 2020

fredrike commented Sep 10, 2020

BeardedTinker commented Sep 11, 2020

fredrike commented Sep 16, 2020

ymartin59 commented Sep 20, 2020

bruvv commented Sep 20, 2020 •

edited

Loading

Add support for Hass.io #3732

Add support for Hass.io #3732

Conversation

fredrike commented Jul 4, 2019

Checklist

chickenandpork commented Jul 11, 2019

fredrike commented Jul 11, 2019

fredrike commented Jul 20, 2019

chickenandpork commented Jul 21, 2019 • edited Loading

fredrike commented Jul 21, 2019 • edited Loading

jokerigno commented Jul 24, 2019

ymartin59 commented Jul 28, 2019

ymartin59 left a comment

Choose a reason for hiding this comment

fredrike commented Aug 1, 2019

fxstein commented Jan 13, 2020

bruvv commented Jan 14, 2020 • edited Loading

G3rry71 commented Jan 14, 2020

jokerigno commented Jan 16, 2020

fredrike commented Jan 16, 2020

fxstein commented Jan 16, 2020

chickenandpork commented Jan 16, 2020 • edited Loading

fredrike commented Jan 18, 2020

chickenandpork commented Jan 18, 2020

fredrike Jan 19, 2020

Choose a reason for hiding this comment

ymartin59 left a comment

Choose a reason for hiding this comment

ymartin59 Jan 19, 2020

Choose a reason for hiding this comment

fredrike commented Jan 20, 2020 • edited Loading

mp68 commented Jan 23, 2020

fredrike Jan 26, 2020

Choose a reason for hiding this comment

ymartin59 commented Jan 26, 2020

ymartin59 commented Jan 26, 2020

dvisser commented Sep 10, 2020

fredrike commented Sep 10, 2020

bruvv commented Sep 10, 2020

fredrike commented Sep 10, 2020

BeardedTinker commented Sep 11, 2020

fredrike commented Sep 16, 2020

ymartin59 commented Sep 20, 2020

bruvv commented Sep 20, 2020 • edited Loading

chickenandpork commented Jul 21, 2019 •

edited

Loading

fredrike commented Jul 21, 2019 •

edited

Loading

bruvv commented Jan 14, 2020 •

edited

Loading

chickenandpork commented Jan 16, 2020 •

edited

Loading

fredrike commented Jan 20, 2020 •

edited

Loading

bruvv commented Sep 20, 2020 •

edited

Loading