-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beets: update to 1.5.0 & Dependencies #4946
Conversation
@ucki would you be willing to try the build above and test that everything is working as intended? |
@publicarray Does it make sense to use recent "requirement" split (from @hgy59 for home assistant) between pure-python wheels to reduce package here too? |
Hi, unfortunatly I am only a "user" so I would be willing to help but I have no clue how to install the package etc ;). |
You just need to use the "Manual Install" button: https://kb.synology.com/en-sg/DSM/tutorial/How_to_install_applications_with_Package_Center#x_anchor_id6 |
@ymartin59 yea maybe but there is lots of movement with python at the moment. I think that can wait for another PR but I can have a quick look. |
@ymartin59 I have no idea how any of this works. How do I know if a dependency is in pure python? I thought this is a pure python package |
37590f1
to
7de5ef8
Compare
@th0ma7 With python 3.10 PyYAML appears to be missing (DSM7)
Other Error I see is FYI I use the following to make is easier to read the logs:
|
@Safihre had provided me with an answer on this #4921 (comment) |
Thanks maybe this belongs in the wiki? |
Oh, it's in the Tips section, but it's not obvious. I'll update it a bit Edit: done 📔 https://github.com/SynoCommunity/spksrc/wiki/Using-wheels-to-distribute-Python-packages#tips-and-tricks |
@publicarray that's odd... and found this in the installation log which probably explains it:
But I think I have a clue why, let me dig into it part of #4951 EDIT: @publicarray in the meantime I've disabled the |
Hm, that's not an error I've seen. I've got a working build now. (works on my machine ™️ ) |
lol... :) I may have found why: this looks like, again, related to my third attempt at bumping EDIT: Actually unrelated... it more seems I was too aggressive at removing all cross/wheels... |
spk/beets/Makefile
Outdated
# Pure Python package, make sure ARCH is not defined | ||
override ARCH= | ||
# override ARCH= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So discard the whole block if package is no longer "non arch"
Hi folks .. sorry for not answering earlier .. wich would the correct version I sould test ? And will it kill my old beets database ? Greetings ucki |
@ucki as @th0ma7 is redesigning the whole bunch of python apps you probably can test the latest builds of #4986.
EDIT: |
Indeed, it is now arch dependent (and sadly it has to). |
@publicarray and @ymartin59 while upgrading to python310 I had to update beets to version 1.5.0 as well. Also conceptually it has now to be a arch dependent package. When looking at the changes I believe "most" of it is already included in master besides refreshing your requirements. Let me know if you need assistance, cheers! |
556ac14
to
61a315b
Compare
I get ModuleNotFoundError: No module named 'yaml' or ERROR: PyYAML-6.0- xxxx .whl is not a supported wheel on this platform.
61a315b
to
639a0c7
Compare
#Pillow==8.2.0 ==> cross/pillow | ||
# Pillow==8.2.0 ==> cross/pillow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #5023 is merged I recommend you to use the python310 commented solution to get Pillow to be cross-compiled using pip
at the version you like instead of using cross/pillow
. It then requires the following in your Makefile
:
# [Pillow]
DEPENDS += cross/freetype cross/libjpeg cross/zlib
WHEELS_BUILD_ARGS += [Pillow]
WHEELS_BUILD_ARGS += build_ext
WHEELS_BUILD_ARGS += --disable-platform-guessing
WHEELS_BUILD_ARGS += --enable-freetype
WHEELS_BUILD_ARGS += --enable-jpeg
WHEELS_BUILD_ARGS += --enable-zlib
because these package versions have conflicting dependencies.
Motivation: The package hasn't been updated in a while.
Linked issues: #4934
https://github.com/beetbox/beets/blob/master/setup.py#L87
install.txt
Test build: https://seby.io/download/synology-7.0/beets_noarch-dsm7_1.5.0-7.spk
Checklist
all-supported
completed successfully