Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setuptools and use get-pip correctly to fix Cryptography build #5316

Merged
merged 6 commits into from
Jun 18, 2022

Conversation

Safihre
Copy link
Contributor

@Safihre Safihre commented Jun 17, 2022

As discussed in #5307 and #4153.
Turns out we need to update setuptools.
I also found that our usage of get-pip.py was wrong: it can't be used to specify the pip version, it always installs whatever they have update the script to.
But by skipping setuptools and wheel in get-pip.py, we can make sure we fix those versions at least.

Successful build of SABnzbd (setup and runs):
https://github.com/Safihre/spksrc/actions/runs/2514098758

@Safihre Safihre requested review from hgy59 and th0ma7 June 17, 2022 09:01
@th0ma7
Copy link
Contributor

th0ma7 commented Jun 17, 2022

@Safihre now I get it, great catch! I recall seing messages that it was replacing a version with another on the subsequent install of wheel and setuptools and that explains it now. Good job!

Copy link
Contributor

@th0ma7 th0ma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restarted the github-action checks to confirm all is good but at first glance this LGTM.

Copy link
Member

@publicarray publicarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! However, I would like the builds for python to succeed.

@Safihre
Copy link
Contributor Author

Safihre commented Jun 18, 2022

I saw 😢 , making changes in a separate branch to fix. Will push when fixed :)

@Safihre
Copy link
Contributor Author

Safihre commented Jun 18, 2022

@hgy59 @publicarray @th0ma7 I fixed python38, but python3 kept failing. I checked and no native/cross/spk uses python3 so I just.. removed it?
Any objections?

@th0ma7
Copy link
Contributor

th0ma7 commented Jun 18, 2022

but python3 kept failing. I checked and no native/cross/spk uses python3 so I just.. removed it? Any objections?

I double checked and indeed it doesn't looked used anymore. So no objection at all besides updating python310 status page #5043

@Safihre
Copy link
Contributor Author

Safihre commented Jun 18, 2022

@Safihre Safihre merged commit 25ea64a into SynoCommunity:master Jun 18, 2022
hgy59 added a commit to hgy59/spksrc that referenced this pull request Jun 18, 2022
- update Python 3.10.4 to v3.10.5 and Python 3.8.12 to v3.8.13
- remove static libpython (3.10 has configure arg, 3.8 needs manual removal)
- pip: install specific version of pip with get-pip.py (revert change by SynoCommunity#5316)
- pip: avoid unintended update of pip with --disable-pip-version-check
@hgy59
Copy link
Contributor

hgy59 commented Jun 18, 2022

@Safihre sorry, as I am too late for the show.
There is nothing wrong with get-pip.py "pip==22.0.4"

I have reintroduced this with #5318.

@hgy59
Copy link
Contributor

hgy59 commented Jun 18, 2022

I also found that our usage of get-pip.py was wrong: it can't be used to specify the pip version, it always installs whatever they have update the script to.

Additional parameters to pip-get.py are documented https://github.com/pypa/get-pip

Upon execution, get-pip.py will install pip, setuptools and wheel in the current Python environment.

It is possible to provide additional arguments to the underlying script. These are passed through to the underlying pip install command, and can thus be used to constraint the versions of the packages, or to pass other pip options such as --no-index.

$ python get-pip.py "pip < 21.0" "setuptools < 50.0" "wheel < 1.0"
$ python get-pip.py --no-index --find-links=/local/copies

@Safihre
Copy link
Contributor Author

Safihre commented Jun 18, 2022

Hmm, strange that I saw in the logs that it wasn't installing the version we specify. I must have misunderstood the logging.

@Safihre Safihre deleted the fixsetuptools branch June 18, 2022 20:44
@hgy59
Copy link
Contributor

hgy59 commented Jun 18, 2022

Hmm, strange that I saw in the logs that it wasn't installing the version we specify. I must have misunderstood the logging.

AFAICR there was "pip = 20.0.4" (single eq) once in your PR...

hgy59 added a commit to hgy59/spksrc that referenced this pull request Jul 1, 2022
- update Python 3.10.4 to v3.10.5 and Python 3.8.12 to v3.8.13
- remove static libpython (3.10 has configure arg, 3.8 needs manual removal)
- pip: install specific version of pip with get-pip.py (revert change by SynoCommunity#5316)
- pip: avoid unintended update of pip with --disable-pip-version-check
hgy59 added a commit that referenced this pull request Jul 2, 2022
* Update Python 3.8 and 3.10
- update Python 3.10.4 to v3.10.5 and Python 3.8.12 to v3.8.13
- remove static libpython (3.10 has configure arg, 3.8 needs manual removal)
- pip: install specific version of pip with get-pip.py (revert change by #5316)
- pip: avoid unintended update of pip with --disable-pip-version-check
* vim: use Python 3.10 for python support
* ffsync does not build anymore
- requirements file handling to create wheels has changed
- might never be working, as still python 2
- future update is redesigned using rust
* fix (optimized) build for DSM 5.2 and 88f6281 (ARMv5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants