Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LandingPage component #233

Closed
wants to merge 1 commit into from
Closed

Added LandingPage component #233

wants to merge 1 commit into from

Conversation

tejartr7
Copy link

Description

Added LandingPage component to the syntaxui, which matches the present

Related Issue

#228
Raised issuse for Adding Landing Page component
Fixes # (228)

Proposed Changes

  • Added LandingPage directory in src/showcase/components
  • Added documentation for LandingPage at src/app/(docs)/components
  • Added credits in credits.md
  • Added Navigation link in src/components/Navigation.tsx

Screenshots

image
image
image

Checklist

Please check the boxes that apply:

  • [ ✅ ] I have rebased my branch on top of the latest main branch.
  • [ ✅ ] I have tested the changes locally
  • [ ✅ ] I ran npm run build and build is successful
  • [ ✅ ] I have added necessary documentation
  • [ ✅ ] I have updated the credits.md file

@tejartr7 tejartr7 requested a review from Ansub as a code owner June 16, 2024 16:18
@epoll31
Copy link
Contributor

epoll31 commented Jun 16, 2024

Hey @tejartr7,

Thanks for opening the issue and the PR. However, we don’t really need this specific component in our showcase. If you have any other ideas, we would love to discuss them either in a new GitHub issue or on our Discord. Feel free to reach out on our Discord if you have any questions :)

@Ansub Ansub closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants