WIP: use class format and add all the tests #2
Conversation
dvd-schwrtz
changed the title
| @@ -1,30 +1,73 @@ | |||
| // @ts-ignore | |||
| import { getSource, getTarget, getSynths, getUsers, toBytes32 } from 'synthetix/browser'; | |||
There was a problem hiding this comment.
This works with the browser example when I import from the browser file
There was a problem hiding this comment.
Not sure how to get it working for node now
There was a problem hiding this comment.
I keep getting ReferenceError: window is not defined for the builds
There was a problem hiding this comment.
So you shouldn't need to specify browser here. Webpack et al will figure out if you are doing a browser based webpack to use the browser field from the synthetix package.json. Likewise if you happen to be doing a node based bundle (which I loathe but necessary if you want to use TypeScript or ES modules), then it will use the main field in the synthetix package.json
| @@ -0,0 +1,44 @@ | |||
| const synthetix = require('../build/index.js')(async () => { | |||
There was a problem hiding this comment.
It would be really nice to be able to run this without requiring a bundler. Perhaps ts-node can do it? But ts-node should only be a devDependency in this case
No description provided.