Fix docker 100% cpu load #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Tested & can confirm that this solves the CPU issues from #38 |
Closed
Closed
edgd1er
added a commit
to edgd1er/py-kms
that referenced
this pull request
Apr 13, 2022
edgd1er
added a commit
to edgd1er/py-kms
that referenced
this pull request
Apr 13, 2022
edgd1er
added a commit
to edgd1er/py-kms
that referenced
this pull request
Apr 14, 2022
edgd1er
added a commit
to edgd1er/py-kms
that referenced
this pull request
Apr 15, 2022
changes after review.
edgd1er
pushed a commit
to edgd1er/py-kms
that referenced
this pull request
Apr 22, 2022
client: add -D to discover KMS server SystemRage#51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #38 - but for docker only.
The problem is that our py-kms tries to use an invalid shell (which is provided by docker or even systemd sometimes) and therefore loops indefinitely. This patch forces docker to provide a valid shell (see here), which should be a acceptable fix for the problem.
The best solution would be to modify py-kms directly by checking at startup for a valid shell (this would then fix this bug for any problematic environment), but this can be really hard (because sometimes we would have a valid shell but e.g. the /dev/null as input).