Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GetElementOrDefault with GetValidElement #212

Merged
merged 10 commits into from
Feb 10, 2023
Merged

Replace GetElementOrDefault with GetValidElement #212

merged 10 commits into from
Feb 10, 2023

Conversation

nnikolopoulos
Copy link
Contributor

Instead of:

GetElementOrDefault<T>(this ICollection<T> array, int index)

have:

GetValidElement<T>(this IList<T> array, int index).

@nnikolopoulos nnikolopoulos added the enhancement New feature or request label Feb 7, 2023
@nnikolopoulos nnikolopoulos added this to the v1.1.x milestone Feb 7, 2023
@nnikolopoulos nnikolopoulos self-assigned this Feb 7, 2023
@nnikolopoulos nnikolopoulos linked an issue Feb 7, 2023 that may be closed by this pull request
Refactor GetElementOrDefault #35
Closed
@nnikolopoulos nnikolopoulos merged commit 3d1ccc1 into develop Feb 10, 2023
@nnikolopoulos nnikolopoulos deleted the 35_RefactorGetElementOrDefault branch February 10, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcolleoni dcolleoni dcolleoni approved these changes

Assignees

@nnikolopoulos nnikolopoulos

Labels
enhancement New feature or request
Projects
IFRS17 Calculation Engine
Status: ✅ Done
Milestone
v1.1.x
Development

Successfully merging this pull request may close these issues.

Refactor GetElementOrDefault
2 participants
@nnikolopoulos @dcolleoni