Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add timeout for test #39

Merged
merged 12 commits into from
May 21, 2024
Merged

[test] Add timeout for test #39

merged 12 commits into from
May 21, 2024

Conversation

hiergaut
Copy link
Contributor

@hiergaut hiergaut commented Apr 10, 2024

Pull Request Desription

Check if you branch history is PR compatible

  • Your branch need to be up to date with origin/main
  • Update your git repository git fetch origin if origin is this remote
  • Check format style with the script provided in scripts/source-format-all.sh
  • You must use clang-format style (github CI version is 11)
  • Your proposal must include a commit where the file CHANGELOG is updated (add a line describing the proposed change + PR id, see file for examples). If your contribution is significant, you can also ask to be added to the contributor list in the discussion.
    These checks are enforced by github workflow actions
    Please refer to the corresponding log in case of failure

UPDATE the form below to describe your PR

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines (see CONTRIBUTING)

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

  • What kind of change does this PR introduce?

    • other: set timeout for tests
  • What is the current behavior? (You can also link to an open issue here)
    The test CI can bug with infinite loop.

  • What is the new behavior (if this is a feature change)?
    Set timeout able to exit tests when test is looping.
    Separate build and test jobs (to show usual test duration).
    Separate clean code jobs.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@hiergaut hiergaut requested a review from nmellado April 10, 2024 11:37
@hiergaut hiergaut marked this pull request as draft April 10, 2024 13:51
@hiergaut hiergaut removed the request for review from nmellado April 15, 2024 08:00
@hiergaut hiergaut marked this pull request as ready for review April 15, 2024 08:04
@hiergaut hiergaut self-assigned this Apr 15, 2024
@hiergaut hiergaut force-pushed the setTestTimeout branch 6 times, most recently from e8545f6 to 1a51c8e Compare April 18, 2024 17:46
@hiergaut hiergaut marked this pull request as draft April 22, 2024 13:12
@hiergaut hiergaut marked this pull request as ready for review April 22, 2024 13:24
@hiergaut
Copy link
Contributor Author

@nmellado ready for review

@hiergaut hiergaut marked this pull request as draft April 29, 2024 10:16
@hiergaut
Copy link
Contributor Author

Ready for review.

@hiergaut hiergaut marked this pull request as ready for review May 1, 2024 09:28
Copy link
Contributor

@nmellado nmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split ccpcheck + clean history

@hiergaut hiergaut added the TOPULL #2 Pull request to be done secondly label May 16, 2024
@hiergaut hiergaut force-pushed the setTestTimeout branch 4 times, most recently from 085e8ad to 68d78d8 Compare May 16, 2024 15:33
@hiergaut
Copy link
Contributor Author

Ready to merge

@nmellado nmellado merged commit c6382a5 into main May 21, 2024
6 checks passed
@nmellado nmellado deleted the setTestTimeout branch May 21, 2024 11:24
@nmellado nmellado removed the TOPULL #2 Pull request to be done secondly label May 21, 2024
hiergaut pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants