-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake][install] Install minor fix #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiergaut
force-pushed
the
installMinorFix
branch
from
April 30, 2024 18:08
7849670
to
88d38ef
Compare
Ready for review. |
This was referenced May 2, 2024
Needs #42 |
This PR will fix export features for x64, UWP-Win32, UWP-ARM64 installation for UnityViewer |
nmellado
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Desription
Check if you branch history is PR compatible
git fetch origin
if origin is this remotescripts/source-format-all.sh
These checks are enforced by github workflow actions
Please refer to the corresponding log in case of failure
UPDATE the form below to describe your PR
Please check if the PR fulfills these requirements
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
Install from external project is broken
What is the new behavior (if this is a feature change)?
Able to install hub for Win32 static only project, and dll only.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: