Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake][install] Install minor fix #49

Merged
merged 15 commits into from
May 21, 2024
Merged

[cmake][install] Install minor fix #49

merged 15 commits into from
May 21, 2024

Conversation

hiergaut
Copy link
Contributor

@hiergaut hiergaut commented Apr 24, 2024

Pull Request Desription

Check if you branch history is PR compatible

  • Your branch need to be up to date with origin/main
  • Update your git repository git fetch origin if origin is this remote
  • Check format style with the script provided in scripts/source-format-all.sh
  • You must use clang-format style (github CI version is 11)
  • Your proposal must include a commit where the file CHANGELOG is updated (add a line describing the proposed change + PR id, see file for examples). If your contribution is significant, you can also ask to be added to the contributor list in the discussion.
    These checks are enforced by github workflow actions
    Please refer to the corresponding log in case of failure

UPDATE the form below to describe your PR

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines (see CONTRIBUTING)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

  • What kind of change does this PR introduce?

    • bug fix
    • feature
    • docs update
    • other:
  • What is the current behavior? (You can also link to an open issue here)
    Install from external project is broken

  • What is the new behavior (if this is a feature change)?
    Able to install hub for Win32 static only project, and dll only.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@hiergaut hiergaut added CMake Update cmake files CI Continuous integration (yml files) labels Apr 24, 2024
@hiergaut hiergaut self-assigned this Apr 24, 2024
@hiergaut
Copy link
Contributor Author

Ready for review.

@hiergaut
Copy link
Contributor Author

Needs #42

@hiergaut hiergaut added the TOPULL #3 Pull request to be done thirdly label May 16, 2024
@hiergaut
Copy link
Contributor Author

This PR will fix export features for x64, UWP-Win32, UWP-ARM64 installation for UnityViewer

@nmellado nmellado merged commit c3a22a6 into main May 21, 2024
3 checks passed
@nmellado nmellado deleted the installMinorFix branch May 21, 2024 09:00
@nmellado nmellado removed the TOPULL #3 Pull request to be done thirdly label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration (yml files) CMake Update cmake files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants