Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Area and Root controller name clashes #51

Closed
artiomchi opened this issue Jun 14, 2017 · 1 comment
Closed

Prevent Area and Root controller name clashes #51

artiomchi opened this issue Jun 14, 2017 · 1 comment
Milestone

Comments

@artiomchi
Copy link
Member

One of the things that should be tackled is preventing the root controllers and area names from clashing.

Say a user has a CatalogsController, and also a Catalogs area with further controllers. The MVC class would have a MVC.Catalogs field for the controller and a MVC.Catalogs property for the area.

I've added a basic check for this, and will rename the area property in the MVC class to MVC.CatalogsArea. All other areas (that don't clash) don't get the suffix.

If someone has a CatalogsAreaController or a CatalogsArea area this will of course cause a clash, but I'm not handling that, since there's no practical reason to have a controller or area named this way :)

Does that sound reasonable?

(a patch to finish this logic will be in the next pull request late this week)

@kevinkuszyk kevinkuszyk added this to the alpha1 milestone Jun 14, 2017
artiomchi added a commit to artiomchi/R4MVC that referenced this issue Jun 14, 2017
! Fixing view class reference for virtual controllers
! Fixing display/editor template registrations
(also seems like I already did T4MVC#51 in previous commits)
@kevinkuszyk
Copy link
Member

Closed via #55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants