Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install System.Memory to fix msbuild update issue #173

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JackGilmore
Copy link

Resolves #172 issues that are breaking R4MVC after the latest Visual Studio update (17.3.3)

@JackGilmore
Copy link
Author

@artiomchi @kevinkuszyk Could either of you review and approve this PR please? This bug is currently causing R4MVC not to work on the latest version of Visual Studio 2022.

@valeriob
Copy link
Contributor

Thank you @JackGilmore , pls @artiomchi could you provide a new version ?

@valeriob
Copy link
Contributor

Gentle ping @artiomchi :D

@valeriob
Copy link
Contributor

valeriob commented Aug 30, 2022

While people wait for it I can provide the nuget package with this change, see the link.
https://1drv.ms/u/s!AqvjZP1RsulxrOo-h4HLVNPMhNNVIw?e=mYjHgs

@jkatsiotis
Copy link

Solving this would be a great help for us as well. When possible please accept the PR. Thanks

@valeriob
Copy link
Contributor

valeriob commented Sep 9, 2022

I get "install-package : Object reference not set to an instance of an object" when trying to install the package from the nupkg file. Is something wrong?

Hi, we installed via a local server and works fine, if you provide more details on what you are doing maybe I can help you.

@hj-w
Copy link

hj-w commented Sep 9, 2022

The .nupkg file from jkatsiotis works! I've added this file as a new package source in package manager settings.

@valeriob
Copy link
Contributor

valeriob commented Oct 3, 2022

Hi @artiomchi or @kevinkuszyk, can you guys take a look at this and release a new package ? it looks like to work fine.
Thanks

@JackGilmore
Copy link
Author

I have sent an email to @artiomchi using the email address on his GitHub profile. Hopefully he picks it up soon and can approve the review 🤞

@valeriob
Copy link
Contributor

valeriob commented Nov 3, 2022

Gentle ping @artiomchi

@jkatsiotis
Copy link

For anyone interested I have uploaded the following on Nuget until (and if) the owners update.

https://www.nuget.org/packages/R4Mvc.Tools.VS2022/

I think I'm giving all relevant credits in the package. Once the official is updated I'll remove that one

@JackGilmore
Copy link
Author

Gentle ping @artiomchi / @kevinkuszyk

1 similar comment
@valeriob
Copy link
Contributor

Gentle ping @artiomchi / @kevinkuszyk

@JackGilmore
Copy link
Author

Gentle nudge @artiomchi @kevinkuszyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error When Generate R4MVC
4 participants