Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit of "Presets" #348

Closed
uli-on opened this issue Jul 24, 2023 · 8 comments
Closed

Unit of "Presets" #348

uli-on opened this issue Jul 24, 2023 · 8 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@uli-on
Copy link

uli-on commented Jul 24, 2023

The Presets setting group needed any unit or descriptive subline to make it unequivocal, I never know is it about JPG quality or scaling percentage (or some third "quality"?)

Great job, BTW, to separate the app into tabs, make the setting groups foldable, and finally: Although I'm not a fan of animations in apps I've to say I love the new transition effects you've chosen, especially the tool headers and the explanatory icon animation of the edit tab.

@T8RIN
Copy link
Owner

T8RIN commented Jul 24, 2023

Thanks!

And about presets, it is scaling percentage and jpg quality if it is less than 100 👀

I can add explanation info button like resize types has

@T8RIN T8RIN added enhancement New feature or request question Further information is requested labels Jul 24, 2023
@uli-on
Copy link
Author

uli-on commented Jul 24, 2023

And about presets, it is scaling percentage and jpg quality if it is less than 100

Does that mean I would get a jpg 90 compression AND 900 px side length if I chose 90 for a square image of 1000px?

@T8RIN
Copy link
Owner

T8RIN commented Jul 24, 2023

Yes!

@uli-on
Copy link
Author

uli-on commented Jul 24, 2023 via email

@T8RIN
Copy link
Owner

T8RIN commented Jul 24, 2023

In this case you can just adjust quality, and nothing breaks then, saving should work using preset f.e. 40 and 100 quality

@uli-on
Copy link
Author

uli-on commented Jul 24, 2023 via email

@T8RIN
Copy link
Owner

T8RIN commented Jul 24, 2023

My pleasure 👀

@uli-on
Copy link
Author

uli-on commented Jul 24, 2023 via email

T8RIN added a commit that referenced this issue Jul 26, 2023
@T8RIN T8RIN closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants