Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/WP-483 - APCD fixes for extensions #268

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

chandra-tacc
Copy link
Contributor

@chandra-tacc chandra-tacc commented Feb 9, 2024

Overview

Submitter calendar can accept duplicates by db design, but non functional in use cases. Business logic / queries need to adjust to that.
The key fields in submitter_calendar are submitter_id, data_period_start.
Submitter_id is distinct for each submitter (org, payor_code). There is no other information in submitter_calendar to derive uniqueness. With the current db design, it is safe to assume the data_period_start should be unique per submitter_id.
If any of the business logic needs to change, that will require db design change.

Related

WP-483

Changes

  • For time period use distinct
  • Change button text to go to dashboard

Testing

  1. Uploaded duplicate rows in test DB:

select calendar_item_id, submitter_id, data_period_start, expected_submission_date from submitter_calendar;

Screenshot 2024-02-08 at 5 35 22 PM

Screenshot with no duplicates in UI.
Screenshot 2024-02-08 at 5 30 08 PM

  1. Tested the exception and successful one shows 'go to dashboard'

Screenshot 2024-02-08 at 5 30 48 PM

Also, navigation took to the dashboard

UI

Notes

@chandra-tacc chandra-tacc changed the title WP-483 - fixes for extensions Bug/WP-483 - APCD fixes for extensions Feb 9, 2024
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

@chandra-tacc chandra-tacc merged commit 26bbbf2 into main Feb 9, 2024
@chandra-tacc chandra-tacc deleted the tasks/WP-483-extension branch February 9, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants