Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-494: handle null entity_names when using exception and extensions in admin view #275

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

chandra-tacc
Copy link
Contributor

@chandra-tacc chandra-tacc commented Feb 15, 2024

Overview

There is bad data in db with empty entity name in submitters table. This is leading to 500 errors in UI.

Related

Changes

  • Fix DB queries so any business logic using the data is not broken - check for both null and empty
  • Do not allow empty strings in dropdown.

Testing

  • Entity name empty strings show up in UI table listing
  • Drop down listing filter out empty entity name.
  1. Admin exception listing - the listing happens with empty entity_name
    http://localhost:8000/administration/list-exceptions/
    Screenshot 2024-02-15 at 12 15 25 PM

  2. Admin extension listing - the listing happens with empty entity_name
    http://localhost:8000/administration/list-extensions/
    Screenshot 2024-02-15 at 12 15 11 PM

UI

Copy link
Contributor

@edmondsgarrett edmondsgarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Chandra

Copy link
Member

@happycodemonkey happycodemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chandra-tacc chandra-tacc merged commit 9a15e2a into main Feb 15, 2024
@chandra-tacc chandra-tacc deleted the hotfix/WP-494-APCD-entityname branch February 15, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants