Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WP-149: Upgrade APCD CMS to Django 4.2 #277

Merged
merged 10 commits into from
Mar 13, 2024

Conversation

edmondsgarrett
Copy link
Contributor

Overview

Related

Changes

  • For cms container, point to Core CMS v4.5.0 (has upgraded Django version)

Testing

  1. Deployed to dev.apcd.tacc.utexas.edu

UI

@edmondsgarrett edmondsgarrett marked this pull request as ready for review March 8, 2024 17:01
Copy link
Contributor

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on dev site

@sophia-massie
Copy link
Contributor

sophia-massie commented Mar 11, 2024

Do we need to update our styles to accommodate Django’s dark mode handling before upgrading Django? I'm using firefox with the automatic color scheme setting that picks up my system preferences - I'm not even explicitly using dark mode in my browser and I imagine users will have their own various settings. The drop down filters are hard to read

Should this be a follow on task or is there a higher level setting for how Django handles dark mode?
Screenshot 2024-03-11 at 11 24 48 AM

@edmondsgarrett
Copy link
Contributor Author

Do we need to update our styles to accommodate Django’s dark mode handling before upgrading Django? I'm using firefox with the automatic color scheme setting that picks up my system preferences - I'm not even explicitly using dark mode in my browser and I imagine users will have their own various settings. The drop down filters are hard to read

Should this be a follow on task or is there a higher level setting for how Django handles dark mode? Screenshot 2024-03-11 at 11 24 48 AM

Going to address this in a follow-on task.

@edmondsgarrett edmondsgarrett merged commit f0111e8 into main Mar 13, 2024
1 check passed
@edmondsgarrett edmondsgarrett deleted the task/WP-149-apcd-cms-django-4.2 branch March 13, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants