Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wp-333 SEARCH_PATH setting #743

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 7, 2023

Overview

Set search URL path via new setting SEARCH_PATH.

Related

Changes

  • added default SEARCH_PATH setting value
  • changed search template to use new SEARCH_PATH setting

Testing

  1. Have a CMS with a Portal.
    Even ECEP, which has Portal scaffolding; and is actually the target client.
  2. Create a test search page in the CMS at a URL with a slug other than search.
  3. Use the search bar to search for "anything".
  4. Verify you are directed to the CMS test page for search.
  5. Verify the query parameter for the search is set to "anything".

UI

Screenshot 2023-11-07 at 2 37 08 PM

Screen.Recording.2023-11-07.at.2.37.16.PM.mov

@wesleyboar wesleyboar added the feature A new feature or replacement of present feature label Nov 7, 2023
@wesleyboar wesleyboar changed the title feat: WI-69 SEARCH_PATH setting feat: WI-333 SEARCH_PATH setting Nov 7, 2023
@wesleyboar wesleyboar changed the title feat: WI-333 SEARCH_PATH setting feat: WP-333 SEARCH_PATH setting Nov 7, 2023
@wesleyboar wesleyboar changed the title feat: WP-333 SEARCH_PATH setting feat: wp-333 SEARCH_PATH setting Nov 7, 2023
@wesleyboar wesleyboar marked this pull request as ready for review November 7, 2023 20:38
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesleyboar wesleyboar merged commit 3123009 into main Nov 7, 2023
@wesleyboar wesleyboar deleted the feat/WI-69-search-path-setting branch November 7, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or replacement of present feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants