Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ospray 0.9 #33

Merged
merged 6 commits into from
Jan 4, 2016
Merged

Ospray 0.9 #33

merged 6 commits into from
Jan 4, 2016

Conversation

GregAbram
Copy link
Member

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

GregAbram added a commit that referenced this pull request Jan 4, 2016
@GregAbram
Merge pull request #33 from TACC/ospray-0.9
02ffa88 
Ospray 0.9
@GregAbram GregAbram merged commit 02ffa88 into dev Jan 4, 2016
@carsonbrownlee
Copy link
Collaborator

Thanks Greg, will test it on my end.
Carson

On Jan 4, 2016, at 4:33 PM, Greg Abram notifications@github.com wrote:

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

You can view, comment on, or merge this pull request online at:

#33

Commit Summary

changes for ospray-0.9
CMake fixes: removed unneeded include dirs, added LINK_PRIVATEs
removed Glyph3DRepresentation
use alignedFree rather than delete[]
back off cxx11 initialization for osp::affine3f in vtkOSPRayRenderable creator
just use in-line code for initialization of osp::affine3f in vtkOSPRayRenderable creator
File Changes

M CMake/FindOSPRay.cmake (118)
M ParaView/CMakeLists.txt (2)
M ParaView/OSPRayView.xml (10)
M VTK/CMakeLists.txt (8)
M VTK/vtkOSPRayCamera.cxx (2)
M VTK/vtkOSPRayLight.cxx (1)
M VTK/vtkOSPRayPolyDataMapper.cxx (127)
M VTK/vtkOSPRayProperty.cxx (7)
M VTK/vtkOSPRayRenderable.h (9)
M VTK/vtkOSPRayRenderer.cxx (27)
M VTK/vtkOSPRayTexture.cxx (5)
M VTK/vtkOSPRayVolumeRayCastMapper.cxx (25)
Patch Links:

https://github.com/TACC/pvOSPRay/pull/33.patch
https://github.com/TACC/pvOSPRay/pull/33.diff
—
Reply to this email directly or view it on GitHub.

@GregAbram
Copy link
Member Author

OK. Right now, with clean pulls of PV and pvOSPRay, things look better than I thought - the geometry does show up. Still problems, though. With GL1, I’m getting the weird sorting problem we saw before Christmas, with the RegionIDs cannot be 0 error. Thought Utkarsh had fixed that. And with GL2 I only get the result from worker 0.

I’ll start working on the camera stuff for saving images

Greg

Gregory D. Abram, Ph.D.
Research Engineering/Scientist Associate
Texas Advanced Computing Center
The University of Texas at Austin
(512) 471-8196
gda@tacc.utexas.edumailto:gda@tacc.utexas.edu

[TACC Website]https://www.tacc.utexas.edu/

Connect With TACChttps://www.tacc.utexas.edu/

On Jan 4, 2016, at 5:08 PM, carsonbrownlee <notifications@github.commailto:notifications@github.com> wrote:

Thanks Greg, will test it on my end.
Carson

On Jan 4, 2016, at 4:33 PM, Greg Abram <notifications@github.commailto:notifications@github.com> wrote:

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

You can view, comment on, or merge this pull request online at:

#33

Commit Summary

changes for ospray-0.9
CMake fixes: removed unneeded include dirs, added LINK_PRIVATEs
removed Glyph3DRepresentation
use alignedFree rather than delete[]
back off cxx11 initialization for osp::affine3f in vtkOSPRayRenderable creator
just use in-line code for initialization of osp::affine3f in vtkOSPRayRenderable creator
File Changes

M CMake/FindOSPRay.cmake (118)
M ParaView/CMakeLists.txt (2)
M ParaView/OSPRayView.xml (10)
M VTK/CMakeLists.txt (8)
M VTK/vtkOSPRayCamera.cxx (2)
M VTK/vtkOSPRayLight.cxx (1)
M VTK/vtkOSPRayPolyDataMapper.cxx (127)
M VTK/vtkOSPRayProperty.cxx (7)
M VTK/vtkOSPRayRenderable.h (9)
M VTK/vtkOSPRayRenderer.cxx (27)
M VTK/vtkOSPRayTexture.cxx (5)
M VTK/vtkOSPRayVolumeRayCastMapper.cxx (25)
Patch Links:

https://github.com/TACC/pvOSPRay/pull/33.patch
https://github.com/TACC/pvOSPRay/pull/33.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/33#issuecomment-168840033.

@carsonbrownlee
Copy link
Collaborator

Gl1 was working for me, gl2 broken due to missing depth issue. For gl1, same error without pvospray right? Perhaps it would be worth letting Utkarsh know.
Carson

On Jan 5, 2016, at 9:44 AM, Greg Abram notifications@github.com wrote:

OK. Right now, with clean pulls of PV and pvOSPRay, things look better than I thought - the geometry does show up. Still problems, though. With GL1, I’m getting the weird sorting problem we saw before Christmas, with the RegionIDs cannot be 0 error. Thought Utkarsh had fixed that. And with GL2 I only get the result from worker 0.

I’ll start working on the camera stuff for saving images

Greg

Gregory D. Abram, Ph.D.
Research Engineering/Scientist Associate
Texas Advanced Computing Center
The University of Texas at Austin
(512) 471-8196
gda@tacc.utexas.edumailto:gda@tacc.utexas.edu

[TACC Website]https://www.tacc.utexas.edu/

Connect With TACChttps://www.tacc.utexas.edu/

On Jan 4, 2016, at 5:08 PM, carsonbrownlee <notifications@github.commailto:notifications@github.com> wrote:

Thanks Greg, will test it on my end.
Carson

On Jan 4, 2016, at 4:33 PM, Greg Abram <notifications@github.commailto:notifications@github.com> wrote:

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

You can view, comment on, or merge this pull request online at:

#33

Commit Summary

changes for ospray-0.9
CMake fixes: removed unneeded include dirs, added LINK_PRIVATEs
removed Glyph3DRepresentation
use alignedFree rather than delete[]
back off cxx11 initialization for osp::affine3f in vtkOSPRayRenderable creator
just use in-line code for initialization of osp::affine3f in vtkOSPRayRenderable creator
File Changes

M CMake/FindOSPRay.cmake (118)
M ParaView/CMakeLists.txt (2)
M ParaView/OSPRayView.xml (10)
M VTK/CMakeLists.txt (8)
M VTK/vtkOSPRayCamera.cxx (2)
M VTK/vtkOSPRayLight.cxx (1)
M VTK/vtkOSPRayPolyDataMapper.cxx (127)
M VTK/vtkOSPRayProperty.cxx (7)
M VTK/vtkOSPRayRenderable.h (9)
M VTK/vtkOSPRayRenderer.cxx (27)
M VTK/vtkOSPRayTexture.cxx (5)
M VTK/vtkOSPRayVolumeRayCastMapper.cxx (25)
Patch Links:

https://github.com/TACC/pvOSPRay/pull/33.patch
https://github.com/TACC/pvOSPRay/pull/33.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/33#issuecomment-168840033.

—
Reply to this email directly or view it on GitHub.

@GregAbram
Copy link
Member Author

Thats right. I’ll ping Utkarsh.

Greg

Gregory D. Abram, Ph.D.
Research Engineering/Scientist Associate
Texas Advanced Computing Center
The University of Texas at Austin
(512) 471-8196
gda@tacc.utexas.edumailto:gda@tacc.utexas.edu

[TACC Website]https://www.tacc.utexas.edu/

Connect With TACChttps://www.tacc.utexas.edu/

On Jan 5, 2016, at 10:46 AM, carsonbrownlee <notifications@github.commailto:notifications@github.com> wrote:

Gl1 was working for me, gl2 broken due to missing depth issue. For gl1, same error without pvospray right? Perhaps it would be worth letting Utkarsh know.
Carson

On Jan 5, 2016, at 9:44 AM, Greg Abram <notifications@github.commailto:notifications@github.com> wrote:

OK. Right now, with clean pulls of PV and pvOSPRay, things look better than I thought - the geometry does show up. Still problems, though. With GL1, I’m getting the weird sorting problem we saw before Christmas, with the RegionIDs cannot be 0 error. Thought Utkarsh had fixed that. And with GL2 I only get the result from worker 0.

I’ll start working on the camera stuff for saving images

Greg

Gregory D. Abram, Ph.D.
Research Engineering/Scientist Associate
Texas Advanced Computing Center
The University of Texas at Austin
(512) 471-8196
gda@tacc.utexas.edumailto:gda@tacc.utexas.edumailto:gda@tacc.utexas.edu

[TACC Website]https://www.tacc.utexas.edu/

Connect With TACChttps://www.tacc.utexas.edu/

On Jan 4, 2016, at 5:08 PM, carsonbrownlee <notifications@github.commailto:notifications@github.commailto:notifications@github.com> wrote:

Thanks Greg, will test it on my end.
Carson

On Jan 4, 2016, at 4:33 PM, Greg Abram <notifications@github.commailto:notifications@github.commailto:notifications@github.com> wrote:

Assuming I'm doing this right, the ospray-0.9 branch contains changes for ospray-0.9

You can view, comment on, or merge this pull request online at:

#33

Commit Summary

changes for ospray-0.9
CMake fixes: removed unneeded include dirs, added LINK_PRIVATEs
removed Glyph3DRepresentation
use alignedFree rather than delete[]
back off cxx11 initialization for osp::affine3f in vtkOSPRayRenderable creator
just use in-line code for initialization of osp::affine3f in vtkOSPRayRenderable creator
File Changes

M CMake/FindOSPRay.cmake (118)
M ParaView/CMakeLists.txt (2)
M ParaView/OSPRayView.xml (10)
M VTK/CMakeLists.txt (8)
M VTK/vtkOSPRayCamera.cxx (2)
M VTK/vtkOSPRayLight.cxx (1)
M VTK/vtkOSPRayPolyDataMapper.cxx (127)
M VTK/vtkOSPRayProperty.cxx (7)
M VTK/vtkOSPRayRenderable.h (9)
M VTK/vtkOSPRayRenderer.cxx (27)
M VTK/vtkOSPRayTexture.cxx (5)
M VTK/vtkOSPRayVolumeRayCastMapper.cxx (25)
Patch Links:

https://github.com/TACC/pvOSPRay/pull/33.patch
https://github.com/TACC/pvOSPRay/pull/33.diff
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/33#issuecomment-168840033.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/33#issuecomment-169057514.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GregAbram @carsonbrownlee