Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: core-cms v4.10 #447

Merged
merged 2 commits into from
Apr 3, 2024
Merged

feat: core-cms v4.10 #447

merged 2 commits into from
Apr 3, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 25, 2024 •
edited
Loading

Overview

Update to Core-CMS v4.10.2.

Important

Deployed to TUP Dev via v1.1.9-202404-02 / #451 at 4f89e3f which is merely two release maintenance commits behind v4.10.2.

Related

Testing

  1. Submit form that does not go to RT e.g.
  2. Verify you receive only 1 confirmation e-mail.
  3. Verify that confirmation e-mail has business hours.
  4. Open Latest News:
    https://dev.tup.tacc.utexas.edu/news/latest-news/
  5. Verify Page Title is "Latest News".
  6. Open Latest News:
    https://dev.tup.tacc.utexas.edu/news/supplemental-news/
  7. Verify Page Title is "Supplemental News".
  8. Test hotfix: tup-714 News "Previous" & "Next" links not working + v4.10 #451.

UI

Steps 1–3

Confirmation E-mail from TUP-CMS Form Submission
CMD-112 and CMD-140 do not affect TUP conf. e-mail. conf email Email form submit

Steps 4–7

Latest News Supplemental News
CMD-107: News Feed Main Page Uses Page Title (Dev Site) Latest News Supplemental News

Step 8

See #451.

Notes

Other Core-CMS v4.10 changes have no effect on TACC because (TACC/Core-CMS#819) TACC already uses Core-Styles v2 and (TACC/Core-CMS#816) TACC still maintains settings_custom.py in its own repo.

@wesleyboar wesleyboar marked this pull request as ready for review March 26, 2024 16:05
@wesleyboar wesleyboar requested review from R-Tomas-Gonzalez and jarosenb and removed request for jarosenb and R-Tomas-Gonzalez March 26, 2024 16:06
@wesleyboar wesleyboar marked this pull request as draft March 26, 2024 16:57
@wesleyboar wesleyboar changed the title feat: core-cms v4.10.0 feat: core-cms v4.10 Mar 26, 2024
@wesleyboar wesleyboar marked this pull request as ready for review April 1, 2024 21:19
wesleyboar
wesleyboar commented Apr 3, 2024
View reviewed changes
apps/tup-cms/Dockerfile Outdated Show resolved Hide resolved
@wesleyboar wesleyboar mentioned this pull request Apr 3, 2024
Merged
@wesleyboar wesleyboar assigned wesleyboar and unassigned wesleyboar Apr 3, 2024
R-Tomas-Gonzalez
R-Tomas-Gonzalez approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Tested 1-8 successfully.

@wesleyboar wesleyboar merged commit 6c6c3ce into main Apr 3, 2024
1 check passed
@wesleyboar wesleyboar deleted the feat/core_cms_v4_10-news_feed_title_from_page-settings_refactor-core_conf_email branch April 3, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Tomas-Gonzalez R-Tomas-Gonzalez R-Tomas-Gonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @R-Tomas-Gonzalez