Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multipage pdf support for fedora #138

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

wwelling
Copy link
Contributor

@wwelling wwelling commented Nov 15, 2023

Description

Add Fedora support for multipage PDF presentation manifests.

Resolves #137

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Start Redis docker container:

docker run -p 6379:6379 redis:4.0.14-alpine

Configure service for Cantaloupe and Fedora:

iiif.image.server.url: https://api.library.tamu.edu/iiif/2
iiif.fedora.url: https://api.library.tamu.edu/fcrepo/rest

Start service:

mvn clean spring-boot:run

Generate presentation manifest at the page container with pdf resource:

http://localhost:9000/fedora/presentation/3b/6f/c3/25/3b6fc325-f6ca-41d8-b91e-8c5db3be8c13/basbanes-texts_objects/2/pages/page_0

Should expect application/json response of presentation manifest with a sequence of 200 canvases, one for each page of the pdf.

image

Can also be tested in Mirador:

https://library.tamu.edu/mirador/?manifest=http://localhost:9000/fedora/presentation/3b/6f/c3/25/3b6fc325-f6ca-41d8-b91e-8c5db3be8c13/basbanes-texts_objects/2/pages/page_0

image

Test Configuration:

  • Toolchain: Maven
  • SDK: Java 11

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented Nov 15, 2023

Coverage Status

coverage: 82.088% (-0.2%) from 82.324%
when pulling e0d6a21 on 137-fedora-multipage-pdf-presentation-manifests
into 664b2eb on main.

Copy link
Member

@jsavell jsavell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on review of code.

I have not tested locally.

@wwelling wwelling merged commit 13302d3 into main Nov 16, 2023
2 checks passed
@wwelling wwelling deleted the 137-fedora-multipage-pdf-presentation-manifests branch November 16, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multipage PDF presentation manifest support for Fedora
3 participants