Dame sprint oct tests #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Case-sensitive OS's may have issues when filenames do not follow the appropriate case-sensitivity.
These were accidentally added at some point.
Implement mock objects and repo objects with structures that match what is expected. Add 'types' list mocking where needed (adding getTypes() function). User Service mock should now provide the expected functionality and return more appropriate results.
The allowableRoles() method only ever gets defined if either isAdmin() or isManager() is true. The final else case will never trigger.
All controllers now have an initializeController() method.
This implements the basic tests to see if WsApi.fetch() or similar are called. More work will be needed for additional tests. Anything that had a problem has been commented out for later completion.
kaladay
requested review from
jcreel,
jeremythuff,
jsavell,
a user and
rladdusaw
ghost
approved these changes
Nov 28, 2018
Use Array.isArray() because typeof does not return "array" for arrays. Add missing semi-colons. Remove no longer needed qInit variable declaration. Actually call the $digest method. Do not call delete on a defined variable, instead assign it to null.
…f isAdmin() and isManager() conditional
kaladay
force-pushed
the
dame-sprint-oct-tests
branch
2 times, most recently
from
27dd9c1 to
721d7fe
Compare
The abstract service mocks do no actually exist as there is no consistent behavior. This provides the same behavior as the model and repo core mocks for consistency and potential future use. Code already provided in the core utility have been removed and replaced.
|
This is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and implement tests.
Controller tests were fully implemented to the extend that I was able to.
Repository tests were only partially implemented.
Directive tests were not implemented.