[B03983] Broadcast last event to in-progress Publishing box - eliminate the spinner #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inate the spinner Remove the spinner. The publishing event log is implemented using a reverse-sorted ordered list for usability and accessibility. The numbered list is not desired, but provided for accessibility and therefore the numbers are hidden via CSS. Implement a custom (simple/naive) filter for event-type-specific presentation. Render the event timestamp for improved user experience. Ensure that when publishing is off and a document update is received that the events log is cleared. Help prevent fast clicking on publish submit button from triggering multiple publishes. (This is still blocked by the service-end, but doing this at least prevents an annoying publish denied error.)
… inside the $q.all() block
Added appropriate mocks. Synchronized utility settings from most recent work. Improve utility promises, using a shared function and adding support for "action". Update mockWsApi with most recent work. Added filters tests. Properly setup karma config template test settings. Comment out ubused app/services include in tests to avoid warning due to having no services tests to process. This implements some of the newer practices for any major changes but follows existing practices for small changes. - Newer practices includes using two spaces instead of four. - Newer practices uses explicit model instantiation. - Newer practices only use 3 mocked models & repos for mocks instead of 6. - Newer practices use $ in the names more. - Newer practices breaks apart unit test initializer functions and settings more granular.
jsavell
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the spinner.
The publishing event log is implemented using a reverse-sorted ordered list for usability and accessibility.
The numbered list is not desired, but provided for accessibility and therefore the numbers are hidden via CSS.
Implement a custom (simple/naive) filter for event-type-specific presentation.
Render the event timestamp for improved user experience.
Ensure that when publishing is off and a document update is received that the events log is cleared.
Help prevent fast clicking on publish submit button from triggering multiple publishes.
(This is still blocked by the service-end, but doing this at least prevents an annoying publish denied error.)
Significant test updates/changes.