[B03986] Create Field Profile modal improvements #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle alerts in the model. Clear the alerts on close. Provide a cancel button. Treat the cancel button and X (close) button as the same. Validation has not been implemented at this time because there appears to be a lot of significant design changes that would be necessary to utilize the weaver validation. While I would prefer to have the buttons in the button section of the model and the messages across the top, these changes were avoided to ensure consistency in existing design.
jsavell
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle alerts in the model.
Clear the alerts on close.
Provide a cancel button.
Treat the cancel button and X (close) button as the same.
Validation has not been implemented at this time because there appears to be a lot of significant design changes that would be necessary to utilize the weaver validation.
While I would prefer to have the buttons in the button section of the model and the messages across the top, these changes were avoided to ensure consistency in existing design.