2019/12 ui test improvements #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newer practices in the UI is to use 2-spaces instead of 4.
The Alert model is a weaver model, so make it the same across different projects. Manually set the project specific channels in the desired tests.
Make sure models that could be used are available for mocking.
…g them with non-test files
This was updated as a result of karma package version updates.
Remove duplicate includes. Make ordering structure more similar to other projects so that they can be more easily compared.
The repo validations object is defined but no way was ever provided to assign some value to it. Provide a `repo.mockValidations` method to give control over mocking the validations object associated with a given repo mock.
… and controller method exists The preferred method would be to use a utility function that accepts a few parameters. The problem with the preferred method is the underlying error reporting in karma does not show the full stack trace using this approach. As a compromize, this implements the same process for every controller. This still results in a size reduction of code by placing the differences in a single array. The error reporting messages are also improved. - Before: "Is the controller defined should be defined for admin" - After: "Is the controller defined for ROLE_ADMIN" - Before: "Are the scope methods defined update role should be defined" - After: "Is the scope method updateRole defined"
I forgot to make these changes in the previous "Update repos" commit.
…e guide test This no-loop-function style guide test is not good advice, but it is simpler to go with it than to ignore it. The resulting code is more confusing and complicated, but avoids the annoyance.
ghost
approved these changes
Feb 11, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make angularui tests in TAMUlib projects more consistent with each other and recent software coding style practices.
Notable changes:
module("templates").