Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 115: Cleanup ServiceType Scaffolding #116

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Sep 18, 2020

There is no longer a settings array.
The username/password do not exist anymore.
The URL and token are now directly on the model.

resolves #115

There is no longer a settings array.
The username/password do not exist anymore.
The URL and token are now directly on the model.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 414

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 96.482%

Totals Coverage Status
Change from base Build 412: -0.04%
Covered Lines: 1234
Relevant Lines: 1279

💛 - Coveralls

@kaladay kaladay merged commit 24a13c5 into sprint7-staging Sep 21, 2020
@ghost ghost deleted the sprint7-115-cleanup_scaffolding branch November 30, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants