Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed solution to use Github account login when Github account name is unavailable #119

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Proposed solution to use Github account login when Github account name is unavailable #119

merged 2 commits into from
Sep 22, 2020

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Sep 21, 2020

resolves #118

@coveralls
Copy link

coveralls commented Sep 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 440

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.482%
Totals Coverage Status
Change from base Build 423: 0.0%
Covered Lines: 1234
Relevant Lines: 1279
💛 - Coveralls

@kaladay kaladay merged commit df0d1e5 into sprint7-staging Sep 22, 2020
@ghost ghost deleted the sprint7-118-account_name_fallback_to_login branch November 30, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rladdusaw rladdusaw Awaiting requested review from rladdusaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaladay @coveralls @rladdusaw