[208] hide title in Mirador viewer #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #208 by using css to hide the title altogether because...
The labels in many of our manifests have multiple entries..
Mirador 2.7.x is hard-coded deep in its bowels to add line breaks between multi-valued entries:
https://github.com/ProjectMirador/mirador/blob/v2.7.0/js/src/utils/jsonLd.js#L61
Line breaks are special in CSS. Pseudo classes don't work on them, and the only cross browser option to neutralize them is with display:none. This hides the break, but without pseudo classes, there's no way to add a space between the entries.
There's also no way to turn the title off in 2.7.x.
In currently unreleased 3.x, the title can be turned off, and
it looks like multi-valued entries are handled better too.