Issue 290: convert travis-ci to github-actions #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this removed, the environment variables should no longer be needed.
…anch for coveralls
4 tasks
ghost
approved these changes
Jan 19, 2021
| uses: actions/cache@v2 | ||
| with: | ||
| path: node_modules | ||
| key: ${{ runner.os }}-cache-node_modules-${{ hashFiles('**/package.json', '**/package-lock.json') }} |
There was a problem hiding this comment.
As we are caching dependencies with node modules and m2 it makes sense to have at least one generic restore key. If we upgrade one dependency there is no reason to not bring in the cache for the remaining dependencies and let npm and mvn fetch the upgrade dependency.
From @wwelling: "As we are caching dependencies with node modules and m2 it makes sense to have at least one generic restore key. If we upgrade one dependency there is no reason to not bring in the cache for the remaining dependencies and let npm and mvn fetch the upgrade dependency."
ghost
reviewed
Jan 19, 2021
| uses: actions/cache@v2 | ||
| with: | ||
| path: ~/.m2/repository | ||
| key: ${{ runner.os }}-cache-maven-${{ hashFiles('**/pom.xml') }} |
There was a problem hiding this comment.
This is not what I meant. I don't think this is correct either. We still want to lookup exact cache if package.json has not changed. But if package.json or pom.xml change it should fall back to a restore key such as:
key: ${{ runner.os }}-cache-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: ${{ runner.os }}-cache-maven-
and
key: ${{ runner.os }}-cache-node_modules-${{ hashFiles('**/package.json') }}
restore-keys: ${{ runner.os }}-cache-node_modules-
This reverts commit 4820e5f. This was a misinterpretation on my part.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #290
resolves #293