Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dame aug sept sprint304 login feature #382

Merged

Conversation

jcreel
Copy link
Member

@jcreel jcreel commented Oct 4, 2021

No description provided.

@coveralls
Copy link

coveralls commented Oct 4, 2021

Coverage Status

Coverage decreased (-0.02%) to 45.61% when pulling becb3df on DAME-Aug-Sept-sprint304-login-feature into 3438258 on DAME-Aug-Sept-sprint-staging.

@rladdusaw rladdusaw force-pushed the DAME-Aug-Sept-sprint304-login-feature branch from a747fb1 to 9b5e5a3 Compare October 5, 2021 19:44
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of AppLoginController on entire body. Also, should try to avoid function calls from template as they are called a lot. But as this is AngularJS and we should just not be working in it anymore, I approve.

@ghost
Copy link

ghost commented Oct 5, 2021

One question, does the link go away after login?

@jcreel jcreel merged commit 43f9288 into DAME-Aug-Sept-sprint-staging Oct 14, 2021
@jcreel jcreel deleted the DAME-Aug-Sept-sprint304-login-feature branch December 23, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants