Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weaver webpack upgrade #436

Merged
16 commits merged into from
Aug 1, 2022
Merged

Weaver webpack upgrade #436

16 commits merged into from
Aug 1, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2022 •
edited by ghost
Loading

Upgrade to weaver webpack build

Caveats

  1. wro required downgrading bootstrap-sass package as ruby sass plugin is not compatible with non-deprecated sass math
  2. appConfig.js must be externalized from jar to afford 12-factor environment config
  3. github workflow required manually converting UI lcov to coveralls.json before combining. previously done by grunt
  4. no longer need to define production or development for maven build as the UI builds based on environment variable now
  5. bundle mirador 3

resolve #422

@coveralls
Copy link

coveralls commented Jul 28, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 45.273% when pulling 32b0677 on weaver-webpack-upgrade into 5805780 on staging.

@ghost ghost requested a review from kaladay July 28, 2022 15:05
@ghost ghost marked this pull request as ready for review July 28, 2022 15:05
@ghost ghost linked an issue Jul 28, 2022 that may be closed by this pull request
Upgrade Weaver-UI-Core (2.2.2-rc.8) #422
Closed
5 tasks
kaladay
kaladay requested changes Jul 29, 2022
View reviewed changes
scripts/build-lighthouse-badges.js Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
karma.conf.js Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@ghost ghost requested a review from kaladay July 30, 2022 21:36
@ghost ghost force-pushed the weaver-webpack-upgrade branch 2 times, most recently from 146844e to 90e7ca5 Compare August 1, 2022 15:53
@ghost ghost merged commit 84c5ee5 into staging Aug 1, 2022
@ghost ghost deleted the weaver-webpack-upgrade branch August 1, 2022 18:50
ghost pushed a commit that referenced this pull request Aug 5, 2022
@rmathew1011 @kaladay
Weaver webpack upgrade (#436) (#440)
43e01a9 
* Error 500 issue resolved for Discovery View click

* Code re-implemented and clean up as per PR review suggestion

* weaver webpack upgrade

mirador update pending

* correct karma conf

* update package.json

* add badges to readme

* passing tests excluding controller tests

* disable lighthouse in workflow

* bundle mirador

* fix broken tests

* remove extra newlines

* remove commented out badges for now

* Relocate files and ensure usable permissions.

* fix mirador bundle build

Co-authored-by: Rincy Mathew <rmathew@tamu.edu>
Co-authored-by: Kevin Day <kday@library.tamu.edu>
Co-authored-by: Kevin Day <35114839+kaladay@users.noreply.github.com>

Co-authored-by: Rincy Mathew <rmathew@tamu.edu>
Co-authored-by: Kevin Day <kday@library.tamu.edu>
Co-authored-by: Kevin Day <35114839+kaladay@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Weaver-UI-Core (2.2.2-rc.8)
3 participants
@coveralls @kaladay @rmathew1011