Issue 401: Cloning modals unresponsive after validation error. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that the id is removed from the form before submitting. This is done to trigger the generation of a new ID automatically on the backend. If the validation fails, the form no longer has the ID. Fix this by saving the ID and restoring the ID to the form if clone submit did not succeed.
kaladay
requested review from
mumptastic,
jeremythuff,
a user and
rmathew1011
This problem also happens in other modals than just the one where the error is reported. Apply the same solution. see: 7ae76c7
rmathew1011
approved these changes
Dec 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem is that the id is removed from the form before submitting. This is done to trigger the generation of a new ID automatically on the backend. If the validation fails, the form no longer has the ID.
Fix this by saving the ID and restoring the ID to the form if clone submit did not succeed.
This same exact problematic logic is in the
ReaderManagementControllerand theWriterManagementController. Given the identical scope, the same fix is applied to each of those as well.Fixes #401
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: