Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script added for google analytics #473

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

rmathew1011
Copy link
Contributor

@rmathew1011 rmathew1011 commented Dec 10, 2022

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #412

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link

Coverage Status

Coverage remained the same at 45.202% when pulling bbcc4c3 on dec_2022_enable_google_analytics into b125a3f on staging.

@kaladay kaladay linked an issue Dec 12, 2022 that may be closed by this pull request
Copy link
Contributor

@kaladay kaladay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like google tag is something that can add google analytics.
I'm trusting using google tag rather than google anyltics to be correct as I have no idea as to the details on how this works.

@rmathew1011 rmathew1011 merged commit d0c57dc into staging Dec 12, 2022
@rmathew1011 rmathew1011 deleted the dec_2022_enable_google_analytics branch December 12, 2022 19:41
@rmathew1011 rmathew1011 mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAGE: Enable Google Analytics
3 participants