Issue 476: Sort order toggle button appends value=undefined to URL, breaking the search. #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reaking the search. There are several areas where the is undefined logic can be improved. Fixing these does not solve the problem and such changes have been omitted. The problem is that the form has an initial value that is undefined. When the form gets submitted, via a search button click or a sort button click, then the undefined gets translated into the string 'undefined'. The immediate solution is to always initialize the value as an empty string before processing any of the URL arguments on first load.
mumptastic
approved these changes
Dec 15, 2022
kaladay
added a commit
that referenced
this pull request
Dec 15, 2022
Remove unused `var i;`. Add additional checks in case `$scope.discoveryContext.search` does not exist. The value, when not used must always be set to an empty string as per #476 resolution via PR #477. Use `angular.isUndefined()` (especiall in place of `!angular.isDefined()`). Reverse the logic in the `$scope.discoveryContext.ascending ? "ASC" : "DESC"` to using `!$scope.discoveryContext.ascending` to enforce the boolean true/false results. Make sure to apply the same safety net of checking `$scope.discoveryContext.search` to `$scope.hasSearch()`.
jeremythuff
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are several areas where the is undefined logic can be improved. Fixing these does not solve the problem and such changes have been omitted.
The problem is that the form has an initial value that is undefined. When the form gets submitted, via a search button click or a sort button click, then the undefined gets translated into the string 'undefined'.
The immediate solution is to always initialize the value as an empty string before processing any of the URL arguments on first load.
Fixes #476
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: