Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 506: Document a possible solution to prevent metadata key enumeration problems. #508

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

kaladay
Copy link
Contributor

@kaladay kaladay commented Jan 17, 2023

Description

Treat the referenced problem as a configuration problem.
Provide documentation in the application.yml to help avoid the situation.

Fixes #506

Type of change

  • This change is a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • No testing needed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@coveralls
Copy link

Coverage Status

Coverage: 45.229% (-0.02%) from 45.252% when pulling 34c65fb on 506-duplicate_key-metadatum-documentation into 6119eb9 on staging.

Copy link
Member

@jcreel jcreel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succinct and clear. The two relevant points in the configuration reference each other for convenience.

@kaladay kaladay merged commit 5f90977 into staging Jan 18, 2023
@kaladay kaladay deleted the 506-duplicate_key-metadatum-documentation branch January 27, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate key value violates unique constraint "internal_metadata_pkey".
3 participants