DiscoHawk meta-issue

[YoshiRulz]

• System.Web dependency is superfluous (see Problematic dependencies #2261). 681b564, f56a981
• MainDiscoForm's icon is loaded from its .resx file, but non-string resources don't work anymore. It's easy enough to use an embedded image instead. a0c7e9c
• Needs assembly load logic copied from EmuHawk's Program, or immediately crashes due to missing assembly BizHawk.Common on Linux. 1a21765
• Remake the Form layouts using *Ex controls and FLPs. not worth it IMO
• Move logic to library projects. f431faf

@adelikat You said you could replace the HttpUtility.UrlDecode call with our path helpers?

[adelikat]

@YoshiRulz : the problem is that discoHawk can not load in the BizHawk.Common library for some reason. THerefore the OSTailoredCode can not be referenced which is required to do this correctly. Better is to also import Client.Common so that we can just use PathUtils.ExeDirectoryPath

Can you look into this dll problem?

If you can look into that problem, we ca

[YoshiRulz]

OSTailoredCode is compiled into the DiscoHawk assembly under a different namespace so it can be used before assembly loading is set up:

BizHawk/src/BizHawk.Client.DiscoHawk/Program.cs

Line 10 in dda8303

using OSTC = EXE_PROJECT.OSTailoredCode;

I can move PathUtils to the same file. EmuHawk's AssemblyResolve handler doesn't use that, though, it just uses Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location).

[adelikat]

All the todos got done, so closing this issue