republishing and storage #21
Conversation
impl/pkg/service/did.go
Outdated
There was a problem hiding this comment.
removing it for now in a follow up
|
|
||
| type PKARRRecord struct { | ||
| // Up to an 1000 byte base64URL encoded string | ||
| V string `json:"v" validate:"required"` |
There was a problem hiding this comment.
Possible to add length validation for these 3 fields?
There was a problem hiding this comment.
it is validated up the call stack, will open an issue for further validation
| @@ -83,3 +132,54 @@ func (s *PKARRService) GetPKARR(ctx context.Context, id string) (*GetPKARRRespon | |||
| Sig: got.Sig, | |||
| }, nil | |||
| } | |||
|
|
|||
| // TODO(gabe) make this more efficient. create a publish schedule based on each individual record, not all records | |||
| func (s *PKARRService) republish() { | |||
There was a problem hiding this comment.
How is this meant to scale? How will sharding work?
There was a problem hiding this comment.
no sharding planned. it will scale better with individual publishing schedules
|
|
||
| // TODO(gabe) make this more efficient. create a publish schedule based on each individual record, not all records | ||
| func (s *PKARRService) republish() { | ||
| allRecords, err := s.db.ListRecords() |
There was a problem hiding this comment.
This call may simply return a subset of all the results. Might need to do some cursor tracking
There was a problem hiding this comment.
agree, will open up an issue for this
| dht: d, | ||
| scheduler: &scheduler, | ||
| } | ||
| if err = scheduler.Schedule(cfg.PKARRConfig.RepublishCRON, service.republish); err != nil { |
There was a problem hiding this comment.
The way this is setup, there will be a republish job for each instance that's running did-dht. Is that intentional?
There was a problem hiding this comment.
intended to run as a single instance
need to add tests