Single signer check #152
Closed
Single signer check #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajakash-dev
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
| @@ -99,6 +99,8 @@ export async function authenticate(jws: GeneralJws, didResolver: DidResolver): P | |||
| // TODO: should we add an explicit check to ensure that there's only 1 signer?, Issue #65 https://github.com/TBD54566975/dwn-sdk-js/issues/65 | |||
| const verifier = new GeneralJwsVerifier(jws); | |||
| const { signers } = await verifier.verify(didResolver); | |||
| if (signers.length!=1) | |||
There was a problem hiding this comment.
style: should wrap all if statements with {... }, looks like a linting rule needs to be added, feel free to add the rule, but that's optional, I can add it in later.
| @@ -99,6 +99,8 @@ export async function authenticate(jws: GeneralJws, didResolver: DidResolver): P | |||
| // TODO: should we add an explicit check to ensure that there's only 1 signer?, Issue #65 https://github.com/TBD54566975/dwn-sdk-js/issues/65 | |||
| const verifier = new GeneralJwsVerifier(jws); | |||
| const { signers } = await verifier.verify(didResolver); | |||
| if (signers.length!=1) | |||
| throw new Error('There must be just 1 signer'); | |||
There was a problem hiding this comment.
A test needs to be added for this new line.
thehenrytsai
requested changes
Nov 14, 2022
There was a problem hiding this comment.
@rajakash-dev, thanks for the PR, a couple of comments to address.
rajakash-dev
force-pushed
the
single-signer-check
branch
from
c4789dc
to
3687f94
Compare
|
Upon further inspection of the code, the issue is already fix by this line of code: Thus closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.